[cert] Make sure DNSNames and IPAddresses are sorted #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshephar
approved these changes
Aug 6, 2024
olliewalsh
reviewed
Aug 7, 2024
modules/certmanager/certificate.go
Outdated
| certificate: certificate, | ||
| timeout: timeout, | ||
| } | ||
|
|
||
| sort.Strings(crt.certificate.Spec.IPAddresses) |
There was a problem hiding this comment.
Sorting as strings will not order by IP address correctly. Could we parse the IPs and then sort (as byte slices I guess)?
There was a problem hiding this comment.
right, let me fix that
There was a problem hiding this comment.
updated and added an ip sort func
To reduce possibility of changing certs, make sure lists of DNSNames and IPAddresses are sorted. Signed-off-by: Martin Schuppert <[email protected]>
Deydra71
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce possibility of changing certs, make sure lists of DNSNames and IPAddresses are sorted.