test: allow fetching CRD from a local replace statement #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibizer
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Could you please extend the test coverage of this in https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/test/crd_test.go with the new path?
Ginkgo test suites require fetching the CRDs of the custom resources used in the tests. Those are fetched from the go.mod and any replace statement is parsed and honoured. Add the ability to process replace statements that point to a local directory as well, to ease the developement process when a project depends on a feature from another project that has not been merged yet.
dciabrin
force-pushed
the
test-crd-local
branch
from
479a7ee to
c2905b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ginkgo test suites require fetching the CRDs of the custom resources used in the tests. Those are fetched from the go.mod and any replace statement is parsed and honoured.
Add the ability to process replace statements that point to a local directory as well, to ease the developement process when a project depends on a feature from another project that has not been merged yet.