Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TLS] Support https/http endpoints #303

Closed
wants to merge 3 commits into from

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Jul 14, 2023

No description provided.

@stuggi stuggi marked this pull request as draft July 14, 2023 11:01
@stuggi stuggi force-pushed the tls_public_endpt branch from f5bb33f to 6f55999 Compare July 14, 2023 13:38
stuggi added 2 commits July 14, 2023 15:39
Adds an OverridSpec to the Route which allows to customize
metadata.Annotations, metadata.Labels and spec of a route. The
override values get merged into the object definition created by
the operator. This allows e.g. to add custom labels, configure
the route via annotations as in [1], or set TLS parameters.

[1] https://docs.openshift.com/container-platform/4.13/networking/routes/route-configuration.html#nw-route-specific-annotations_route-configuration

Jira: OSP-21715
Jira: OSP-26299
Allows register https endpoints when certificate is provided via
the endpoint override.

Depends-On: openstack-k8s-operators#293

Jira: OSP-26299
@stuggi stuggi force-pushed the tls_public_endpt branch 4 times, most recently from cc12288 to f408b00 Compare July 17, 2023 06:36
Comment on lines +202 to +203
// TODO create TLS cert if non provided in override and data.Protocol == ProtocolHTTPS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could allow the user to provide the annotations required for cert-manager since they already have access to routeOverrides via the other piece of work:
#293

Maybe we should preference that if users want TLS rather than implementing our own logic to generate TLS certs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could allow the user to provide the annotations required for cert-manager since they already have access to routeOverrides via the other piece of work: #293

Maybe we should preference that if users want TLS rather than implementing our own logic to generate TLS certs?

sure, for public endpoints (route) a user can overwrite certs for public endpoints via my other PR you mentioned. but for tls-e need to create them based on the cert-manager issuer . I don't think for those it will work well if a user has to provide all the certs.

Allows to pass in TLSConfig settings the the openstackclient
for register e.g. endpoints.
The config can be a list of CACert's, Insecure parameter and
client cert/key.

Jira: OSP-26299
@stuggi stuggi force-pushed the tls_public_endpt branch from f408b00 to 944cef0 Compare July 17, 2023 09:40
@stuggi stuggi closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants