Merge pull request #395 from stuggi/getissuerbyname

[certmanager] Adds func GetIssuerByName() to get an issuer by name

modules/certmanager/issuer.go

@@ -26,6 +26,7 @@ import (
 	"github.com/openstack-k8s-operators/lib-common/modules/common/util"
 	k8s_errors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/types"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
 )
@@ -146,3 +147,21 @@ func (i *Issuer) Delete(
 
 	return nil
 }
+
+// GetIssuerByName - get certmanager issuer by name
+func GetIssuerByName(
+	ctx context.Context,
+	h *helper.Helper,
+	name string,
+	namespace string,
+) (*certmgrv1.Issuer, error) {
+
+	issuer := &certmgrv1.Issuer{}
+
+	err := h.GetClient().Get(ctx, types.NamespacedName{Name: name, Namespace: namespace}, issuer)
+	if err != nil {
+		return nil, fmt.Errorf("Error getting issuer %s: %w", issuer.Name, err)
+	}
+
+	return issuer, nil
+}

modules/certmanager/test/functional/certmanager_test.go

@@ -36,10 +36,16 @@ var _ = Describe("certmanager module", func() {
 
 		_, err := i.CreateOrPatch(ctx, h)
 		Expect(err).ShouldNot(HaveOccurred())
-		issuer := th.GetIssuer(names.SelfSignedIssuerName)
-		Expect(issuer.Spec.SelfSigned).NotTo(BeNil())
-		Expect(issuer.Labels["f"]).To(Equal("l"))
-
+		Eventually(func(g Gomega) {
+			issuer, err := certmanager.GetIssuerByName(
+				th.Ctx,
+				h,
+				names.SelfSignedIssuerName.Name,
+				names.SelfSignedIssuerName.Namespace)
+			g.Expect(err).NotTo(HaveOccurred())
+			g.Expect(issuer.Spec.SelfSigned).NotTo(BeNil())
+			g.Expect(issuer.ObjectMeta.Labels["f"]).To(Equal("l"))
+		}, timeout, interval).Should(Succeed())
 	})
 
 	It("creates CA issuer", func() {