Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CONTROLLER_TOOLS_VERSION to 0.14.0 #516

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Dec 9, 2024

bump controller tools to the version which bumps k8s deps to v0.29.0, which aligns with the version in the operators.

bump controller tools to the version which bumps k8s deps to
v0.29.0, which aligns with the version in the operators.

Signed-off-by: Martin Schuppert <[email protected]>
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d23f818 into openstack-k8s-operators:main Dec 9, 2024
6 checks passed
amoralej added a commit to amoralej/watcher-operator that referenced this pull request Dec 10, 2024
bump controller tools to the version which bumps k8s deps to
v0.29.0, which aligns with the version in the operators.

We need it for make generate to work fine. Taken from [1].

[1] openstack-k8s-operators/keystone-operator#516
amoralej added a commit to amoralej/watcher-operator that referenced this pull request Dec 10, 2024
bump controller tools to the version which bumps k8s deps to
v0.29.0, which aligns with the version in the operators.

We need it for make generate to work fine. Taken from [1].

[1] openstack-k8s-operators/keystone-operator#516
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/watcher-operator that referenced this pull request Dec 10, 2024
bump controller tools to the version which bumps k8s deps to
v0.29.0, which aligns with the version in the operators.

We need it for make generate to work fine. Taken from [1].

[1] openstack-k8s-operators/keystone-operator#516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants