Add tests for custom number of fernet keys #497
Merged
+258
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afaranha
force-pushed
the
fix_fernet_functional_tests
branch
2 times, most recently
from
6357488 to
398f4f4
Compare
afaranha
force-pushed
the
fix_fernet_functional_tests
branch
from
398f4f4 to
9449254
Compare
stuggi
reviewed
Nov 28, 2024
| @@ -1195,8 +1195,9 @@ func (r *KeystoneAPIReconciler) generateServiceConfigMaps( | |||
| instance.Status.DatabaseHostname, | |||
| keystone.DatabaseName, | |||
| ), | |||
| "enableSecureRBAC": instance.Spec.EnableSecureRBAC, | |||
| "ProcessNumber": instance.Spec.HttpdCustomization.ProcessNumber, | |||
| "ProcessNumber": instance.Spec.HttpdCustomization.ProcessNumber, | |||
There was a problem hiding this comment.
not related to this PR, but @Deydra71 we might want to add some functional tests for the ProcessNumber?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afaranha, stuggi, xek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 82bb2a7
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.