Update keystoneapi to use service override #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
This was referenced Sep 7, 2023
stuggi
force-pushed
the
handle_ingress_v3
branch
4 times, most recently
from
29ec0f5 to
8273614
Compare
stuggi
force-pushed
the
handle_ingress_v3
branch
6 times, most recently
from
3083b07 to
dcbfe2c
Compare
Removes creation of routes for keystoneapi as those get done in the openstack-operator. Via service overrides the parts of the service can be customized. The service operator adds annotation to the service which needs to be exposed as a route. Jira: OSP-26690 Depends-On: openstack-k8s-operators/lib-common#332
With [1] the domain ID can be passed to project and user resurces. With [2] the default domain ID gets already passed for creating the user, lets also set it on the project. [1] openstack-k8s-operators/lib-common#314 [2] openstack-k8s-operators@d73d07c
stuggi
force-pushed
the
handle_ingress_v3
branch
from
dcbfe2c to
b4717cb
Compare
stuggi
requested review from
dprince,
abays and
olliewalsh
and removed request for
viroel and
Sandeepyadav93
|
/test keystone-operator-build-deploy-kuttl |
1 similar comment
|
/test keystone-operator-build-deploy-kuttl |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-robot
merged commit 92ae026
into
openstack-k8s-operators:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes creation of routes for keystoneapi as those get done in the openstack-operator. Via service overrides the parts of the service can be customized. The service operator adds annotation to the service which needs to be exposed as a route.
Jira: OSP-26690
Depends-On: openstack-k8s-operators/lib-common#332