Do not delete KeystoneService with associated KeystoneEndpoint #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
|
/test keystone-operator-build-deploy-kuttl The issue with Galera assertion is supposed to be fixed now. |
|
/test keystone-operator-build-deploy-kuttl |
2 similar comments
|
/test keystone-operator-build-deploy-kuttl |
|
/test keystone-operator-build-deploy-kuttl |
kajinamit
changed the title
The KeystoneEndpoint CR is dependent on the KeystoneService CR, because keystone endpoints requires that the target service is created in advance. This adds the finalizer to avoid removing KeystoneService before all associated KeystoneEndpoint instances are deleted.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, kajinamit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KeystoneEndpoint CR is dependent on the KeystoneService CR, because keystone endpoints requires that the target service is created in advance.
This adds the finalizer to avoid removing KeystoneService before all associated KeystoneEndpoint instances are deleted.