Support exposing service via metallb

[stuggi]

• renames NetworkAttachmentDefinitions to NetworkAttachments
• introduce externalEndpoints Parameters to configure metallb service using the pre-created metallb IPAddressPool and L2Advertisement .

E.g. to expose the api on an internalapi network which

• should be registered as the internal endpoint
• its metallb ipaddresspool is configured in an osp-internalapi object
• and request a specific loadbalancerIP which is shared with other services (list of IPs for multi stack ipv4/ipv6)

...
spec:
...
      externalEndpoints:
      - endpoint: internal
        loadbalancerIPs:
        - 172.17.0.202
        ipAddressPool: osp-internalapi
        sharedIP: true

• removes registration of admin endpoint

Depends-On: openstack-k8s-operators/lib-common#160

[stuggi]

# openstack endpoint list
+----------------------------------+-----------+--------------+--------------+---------+-----------+-----------------------------------------------------------------+
| ID                               | Region    | Service Name | Service Type | Enabled | Interface | URL                                                             |
+----------------------------------+-----------+--------------+--------------+---------+-----------+-----------------------------------------------------------------+
| 040fa92602564b2c9421bd6d375683d4 | regionOne | keystone     | identity     | True    | internal  | http://keystone-internal.openstack.svc:5000                     |
| 6947e88973714c20a42266eb49d41d8c | regionOne | keystone     | identity     | True    | public    | http://keystone-public-openstack.apps.ostest.test.metalkube.org |
+----------------------------------+-----------+--------------+--------------+---------+-----------+-----------------------------------------------------------------+

[gibizer]

The code looks good to me but I have limited knowledge around metallb.

[stuggi]

/hold

[abays]

I wonder if eventually we might want to surface this in the conditions, but I suppose it will be rare for that nad.CreateNetworksAnnotation(...) func to ever return an error.

[abays]

+1 from me

[stuggi]

/unhold

[gibizer]

looks good to me

[stuggi]

/test keystone-operator-build-deploy

[olliewalsh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [olliewalsh,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment