Use new nad.EnsureNetworksAnnotation() func to get NAD annotations #496
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuggi
requested review from
olliewalsh and
lmiccini
and removed request for
abays and
frenzyfriday
stuggi
force-pushed
the
nad_annotation_gw
branch
from
b635cfc to
45e7e94
Compare
For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure `ipam.gateway` in the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. If `ipam.gateway` is defined and not "", it gets set on the networks annotation as the `default-route`. Jira: https://issues.redhat.com/browse/OSPRH-8680 Depends-On: openstack-k8s-operators/lib-common#579 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
force-pushed
the
nad_annotation_gw
branch
from
45e7e94 to
9d2ec23
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fcfd1c9
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure
ipam.gatewayin the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. Ifipam.gatewayis defined and not "", it gets set on the networks annotation as thedefault-route.Jira: https://issues.redhat.com/browse/OSPRH-8680
Depends-On: openstack-k8s-operators/lib-common#579