Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObservedGeneration to the sub Resources #417

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Apr 19, 2024

This patch does a few things:

  1. it adds observedGeneration to the sub custom resources
  2. it proposes to bump the observedGeneration at the beginning of the reconciliation loop (metadata.observedGeneration behaves differently across CRDs knative/serving#4937)
  3. it checks, at the top level, if the observedGeneration matches with the metadata.generation assigned to the subCR(s); if it's the latest version, the condition is mirrored
  4. before marking DeploymentReadyCondition as True in the subCRs, observedGeneration is compared with the generation of the Deployment/Statefulset
  5. it updates the functional tests and bumps both lib-common/modules/test and lib-common/modules/common

@fmount fmount requested review from steveb and dprince April 19, 2024 10:48
@openshift-ci openshift-ci bot requested review from frenzyfriday and viroel April 19, 2024 10:48
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/85944e8bc05642ca927f26d5a4a37e07

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 10m 56s
podified-multinode-ironic-deployment FAILURE in 44m 27s

@fmount
Copy link
Contributor Author

fmount commented Apr 19, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2b356811c5cc48c3a03d9b2daa932456

✔️ openstack-k8s-operators-content-provider SUCCESS in 23m 37s
podified-multinode-ironic-deployment RETRY_LIMIT in 4s

@abays
Copy link
Contributor

abays commented Apr 19, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ac9a0876beb84104851243adb192f0da

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 55s
podified-multinode-ironic-deployment FAILURE in 44m 48s

@fmount
Copy link
Contributor Author

fmount commented Apr 23, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4cd5314e1ace4724b0ebd855e236f339

openstack-k8s-operators-content-provider FAILURE in 9m 47s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor Author

fmount commented Apr 23, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4ed4bf8363694952b26d92faec9dee45

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 05m 19s
podified-multinode-ironic-deployment FAILURE in 43m 41s

@juliakreger
Copy link
Contributor

recheck

This patch does a few things:
1. it adds observedGeneration to the sub custom resources
2. it proposes to bump the observedGeneration at the beginning of the
   reconciliation loop (knative/serving#4937)
3. it checks, at the top level, if the ObservedGeneration matches with
   the metadata.generation assigned to the subCR(s); if it's the latest
   version, the condition is mirrored
4. before marking the DeploymentReadyCondition as True in the subCRs,
   the ObservedGeneration is compared with the Generation of the
   Deployment/ Statefulset
5. it updates the functional tests and bumps both lib-common test and
   common modules

Signed-off-by: Francesco Pantano <[email protected]>
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

New changes are detected. LGTM label has been removed.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ed1fa8d63b454d36b1026556eb0a1ed2

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 42m 07s
podified-multinode-ironic-deployment FAILURE in 18m 40s

@fmount
Copy link
Contributor Author

fmount commented Apr 30, 2024

recheck

@stuggi stuggi added the lgtm label Apr 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5c245a5 into openstack-k8s-operators:main Apr 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants