-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ObservedGeneration to the sub Resources #417
Add ObservedGeneration to the sub Resources #417
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/85944e8bc05642ca927f26d5a4a37e07 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 10m 56s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/2b356811c5cc48c3a03d9b2daa932456 ✔️ openstack-k8s-operators-content-provider SUCCESS in 23m 37s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ac9a0876beb84104851243adb192f0da ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 55s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4cd5314e1ace4724b0ebd855e236f339 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 47s |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4ed4bf8363694952b26d92faec9dee45 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 05m 19s |
recheck |
This patch does a few things: 1. it adds observedGeneration to the sub custom resources 2. it proposes to bump the observedGeneration at the beginning of the reconciliation loop (knative/serving#4937) 3. it checks, at the top level, if the ObservedGeneration matches with the metadata.generation assigned to the subCR(s); if it's the latest version, the condition is mirrored 4. before marking the DeploymentReadyCondition as True in the subCRs, the ObservedGeneration is compared with the Generation of the Deployment/ Statefulset 5. it updates the functional tests and bumps both lib-common test and common modules Signed-off-by: Francesco Pantano <[email protected]>
New changes are detected. LGTM label has been removed. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ed1fa8d63b454d36b1026556eb0a1ed2 ✔️ noop SUCCESS in 0s |
recheck |
5c245a5
into
openstack-k8s-operators:main
This patch does a few things:
observedGeneration
to the sub custom resourcesobservedGeneration
at the beginning of the reconciliation loop (metadata.observedGeneration behaves differently across CRDs knative/serving#4937)observedGeneration
matches with themetadata.generation
assigned to thesubCR(s)
; if it's the latest version, the condition is mirroredDeploymentReadyCondition
as True in thesubCRs
,observedGeneration
is compared with thegeneration
of theDeployment
/Statefulset
lib-common/modules/test
andlib-common/modules/common