Use defaults for force_power_state_during_sync, automated_clean #401
Conversation
These were set to non-default values based on undercloud configuration, not overcloud. Defaults are more appropriate for a BMaaS service.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/bd2d08e552b447ab9bd217260924ea59 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 00s |
|
It looks like this is breaking on the extra testing: Specifically internal to the job a tempest test is failing. Well, Multiple tests are failing related to the following issue: https://bugs.launchpad.net/ironic/+bug/2054722 We're likely going to need to just exclude the allocations tests. They are less fundamentally important anyhow to the base operation of Ironic as a service, and were added to support Metalsmith scheduling use case. |
Ironic, internally, has a lightweight allocation engine, originally added for metalsmith usage ages ago. Turns out its unit tests can fail when running automated cleaning combined with default deployment interface which is not the fake driver. This was not detected upstream because only the fake drivers are executed together. Needed for: openstack-k8s-operators/ironic-operator#401 Signed-off-by: Julia Kreger <[email protected]>
Ironic, internally, has a lightweight allocation engine, originally added for metalsmith usage ages ago. Turns out its unit tests can fail when running automated cleaning combined with default deployment interface which is not the fake driver. This was not detected upstream because only the fake drivers are executed together. Needed for: openstack-k8s-operators/ironic-operator#401 Signed-off-by: Julia Kreger <[email protected]>
|
recheck openstack-k8s-operators/ci-framework#1187 is merged now. |
openshift-merge-bot
bot
merged commit b28a67c
into
openstack-k8s-operators:main
Ironic, internally, has a lightweight allocation engine, originally added for metalsmith usage ages ago. Turns out its unit tests can fail when running automated cleaning combined with default deployment interface which is not the fake driver. This was not detected upstream because only the fake drivers are executed together. Needed for: openstack-k8s-operators/ironic-operator#401 Signed-off-by: Julia Kreger <[email protected]>
Ironic, internally, has a lightweight allocation engine, originally added for metalsmith usage ages ago. Turns out its unit tests can fail when running automated cleaning combined with default deployment interface which is not the fake driver. This was not detected upstream because only the fake drivers are executed together. Needed for: openstack-k8s-operators/ironic-operator#401 Signed-off-by: Julia Kreger <[email protected]>
These were set to non-default values based on undercloud configuration, not overcloud. Defaults are more appropriate for a BMaaS service.