Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[envtest]Use keystone helpers from keystone-operator #337

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Sep 25, 2023

This was necessary to remove a dependency cycle from lib-common

Depends-On: #334 (merged)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

This was necessary to remove a dependency cycle from lib-common
@gibizer gibizer force-pushed the keystone-test-helper branch from fda402f to 5184ccc Compare September 26, 2023 09:47
@gibizer
Copy link
Contributor Author

gibizer commented Sep 26, 2023

/unhold

@gibizer gibizer marked this pull request as ready for review September 26, 2023 09:47
@openshift-ci openshift-ci bot requested review from hjensas and viroel September 26, 2023 09:47
@gibizer gibizer changed the title Keystone test helper [envtest]Use keystone helpers from keystone-operator Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@gibizer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ironic-operator-build-deploy-tempest 5184ccc link false /test ironic-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gibizer
Copy link
Contributor Author

gibizer commented Sep 26, 2023

The tempest job will fail until the Route for ironic-api is created in the openstack-operator. openstack-k8s-operators/openstack-operator#488

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, hjensas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 27e7523 into openstack-k8s-operators:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants