Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metallb into infra_prep #982

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Dec 17, 2024

With [1] the infra-operator provides a CRD to manage FRRConfiguration for secondary network interfaces in a BGP environment. Therefore this CRD should be installed when the infra-operator gets deployed. This ass the metallb target to the infra_prep.

[1] openstack-k8s-operators/infra-operator#322

@openshift-ci openshift-ci bot requested review from fultonj and raukadah December 17, 2024 08:01
@stuggi stuggi requested a review from abays December 17, 2024 08:05
@stuggi
Copy link
Contributor Author

stuggi commented Dec 17, 2024

its a follow up to #975 for the non kuttl standalone deploy use case.

With [1] the infra-operator provides a CRD to manage FRRConfiguration
for secondary network interfaces in a BGP environment. Therefore this
CRD should be installed when the infra-operator gets deployed. This
adds the metallb target to the infra_prep.

[1] openstack-k8s-operators/infra-operator#322

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi stuggi force-pushed the infra_prep_metallb branch from e5c7de7 to 42efaa2 Compare December 17, 2024 09:56
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 11e411a into openstack-k8s-operators:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants