Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Install metallb per default" #979

Closed
wants to merge 1 commit into from

Conversation

karelyatin
Copy link
Contributor

Reverts #975

It broke openstack-operator kuttl job.

@openshift-ci openshift-ci bot requested review from dprince and fmount December 16, 2024 13:52
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Dec 16, 2024

this was introduced because of a broken kuttl tests. the infra-operator now required the metallb CRD do be installed for managing FRR configurations for BGP environments.

@stuggi
Copy link
Contributor

stuggi commented Dec 16, 2024

adding a hold for now

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/04ac0d55537d4c289dbdd7dd182a336d

openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007705168 failed in 0s
⚠️ install-yamls-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@karelyatin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/install-yamls-deploy 501838b link false /test install-yamls-deploy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@karelyatin
Copy link
Contributor Author

it confirmed that this patch triggered the issue and now issue in openstack-operator kuttl tests is fixed with openstack-k8s-operators/infra-operator#331

@karelyatin karelyatin closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants