-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logically bound images #950
Add logically bound images #950
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3a2810d
to
18d3da9
Compare
This change adds logically bound images for use with bootc. This is implementing based on: https://containers.github.io/bootc/logically-bound-images.html Signed-off-by: Brendan Shephard <[email protected]>
18d3da9
to
00650e7
Compare
runAsUser: 42405 | ||
seLinuxOptions: | ||
type: ceilometer_polling_t | ||
volumeMounts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some method of handling TLS mount requirements. It could be a matter of copying this as a base and using Ansible to add the requirements, then write the output to /etc
.
Or, we could use a OpenShift build. Render a Containerfile that inherits from our base EDPM image, Go template this file into a ConfigMap with all of the requirements based on the cloud we're deploying too. Then bootc switch
to that image on the EDPM nodes during the deployment.
value: COPY_ALWAYS | ||
- name: OS_ENDPOINT_TYPE | ||
value: internal | ||
image: quay.io/podified-antelope-centos9/openstack-ceilometer-compute:current-podified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be dynamically configurable
name: etc-localtime-host-9 | ||
readOnly: true | ||
hostNetwork: true | ||
hostname: edpm-compute-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be dynamically configurable
Can this be moved to edpm-image-builder/bootc? |
It can indeed. |
Replaced by: |
This change adds logically bound images for use with bootc. This is implementing based on: https://containers.github.io/bootc/logically-bound-images.html
Jira: https://issues.redhat.com/browse/OSPRH-11609