Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Octavia in Standalone deployment #560

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Enable Octavia in Standalone deployment #560

merged 1 commit into from
Oct 2, 2023

Conversation

weinimo
Copy link
Contributor

@weinimo weinimo commented Oct 2, 2023

This allows testing Octavia data plane adoption in the development environment.

@openshift-ci openshift-ci bot requested review from dprince and stuggi October 2, 2023 10:27
OctaviaForwardAllLogs: true
StandaloneExtraConfig:
nova::compute::libvirt::services::libvirt_virt_type: kvm
nova::compute::libvirt::virt_type: kvm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a separate PR as it is not related to Octavia?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Octavia requires nested virtualization, so I think it's fine to have it in this PR,
that said, on line 64 we have NovaComputeLibvirtType: qemu which contradicts these 2 options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ git grep NovaComputeLibvirtType
deployment/nova/nova-modular-libvirt-container-puppet.yaml:  NovaComputeLibvirtType:
deployment/nova/nova-modular-libvirt-container-puppet.yaml:            nova::compute::libvirt::services::libvirt_virt_type: {get_param: NovaComputeLibvirtType}
deployment/nova/nova-modular-libvirt-container-puppet.yaml:            nova::compute::libvirt::virt_type: {get_param: NovaComputeLibvirtType}

I think that NovaComputeLibvirtType: kvm should be enough

Copy link
Contributor Author

@weinimo weinimo Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I removed the NovaComputeLibvirtType line because kvm is the default

I can set it explicitly if you prefer, however.

This allows testing Octavia data plane adoption in the development
environment.

Removed the configuration that sets NovaComputeLibvirtType to qemu.
Octavia needs nested virtualization support. Hence kvm should be used,
which is the default for this setting.
@fao89
Copy link
Contributor

fao89 commented Oct 2, 2023

/approve

@openshift-ci openshift-ci bot added the approved label Oct 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, hjensas, weinimo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d85af9b into openstack-k8s-operators:main Oct 2, 2023
@weinimo weinimo deleted the octavia-adoption branch October 4, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants