-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Octavia in Standalone deployment #560
Enable Octavia in Standalone deployment #560
Conversation
devsetup/standalone/openstack.sh
Outdated
OctaviaForwardAllLogs: true | ||
StandaloneExtraConfig: | ||
nova::compute::libvirt::services::libvirt_virt_type: kvm | ||
nova::compute::libvirt::virt_type: kvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a separate PR as it is not related to Octavia?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Octavia requires nested virtualization, so I think it's fine to have it in this PR,
that said, on line 64 we have NovaComputeLibvirtType: qemu
which contradicts these 2 options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ git grep NovaComputeLibvirtType
deployment/nova/nova-modular-libvirt-container-puppet.yaml: NovaComputeLibvirtType:
deployment/nova/nova-modular-libvirt-container-puppet.yaml: nova::compute::libvirt::services::libvirt_virt_type: {get_param: NovaComputeLibvirtType}
deployment/nova/nova-modular-libvirt-container-puppet.yaml: nova::compute::libvirt::virt_type: {get_param: NovaComputeLibvirtType}
I think that NovaComputeLibvirtType: kvm
should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I removed the NovaComputeLibvirtType
line because kvm is the default
I can set it explicitly if you prefer, however.
This allows testing Octavia data plane adoption in the development environment. Removed the configuration that sets NovaComputeLibvirtType to qemu. Octavia needs nested virtualization support. Hence kvm should be used, which is the default for this setting.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, hjensas, weinimo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows testing Octavia data plane adoption in the development environment.