Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dns cluster info from lib common get function #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

averdagu
Copy link

@averdagu averdagu commented Dec 10, 2024

Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators.

Resolves: OSPRH-3627
Depends-on: openstack-k8s-operators/lib-common#580

@openshift-ci openshift-ci bot requested review from lewisdenny and stuggi December 10, 2024 11:53
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: averdagu
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/443453756b354ddf9b76b2532f6edcd2

openstack-k8s-operators-content-provider FAILURE in 6m 39s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@averdagu averdagu force-pushed the feat/use-dns-cluster-lib-common branch 2 times, most recently from 044dc5c to f7d5dd8 Compare December 10, 2024 15:59
Openshift coreDNS creates the domain name using an string
located in dnses.operator.openshift.io. This string can
change in the future, calling lib-common/GetDNSClusterDomain
the responsability of gathering this information correctly
only falls under lib-common intead of all operators.

Resolves: OSPRH-3627
Depends-on: openstack-k8s-operators/lib-common#580
@averdagu averdagu force-pushed the feat/use-dns-cluster-lib-common branch from f7d5dd8 to ea904cb Compare December 10, 2024 16:54
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/83e19f83df254b2e91304446bc735033

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 32s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 54s

@karelyatin
Copy link

/retest

@karelyatin
Copy link

recheck
/lgtm

@karelyatin
Copy link

/test infra-operator-build-deploy-kuttl
kuttl jobs fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants