-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0-fr1] Ensure nodeSelector logic is consistent for all operators #316
[18.0-fr1] Ensure nodeSelector logic is consistent for all operators #316
Conversation
Switch to a pointer for nodeSelector to allow different logic for empty vs unset
3e52826
to
36bfe92
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0d5dc4ea99b74ea2ae0b78cc8c7c7d04 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 59s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override rdoproject.org/github-check |
@olliewalsh: Overrode contexts on behalf of olliewalsh: rdoproject.org/github-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/infra-operator-build-deploy ci/prow/infra-operator-build-deploy-kuttl |
@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/infra-operator-build-deploy, ci/prow/infra-operator-build-deploy-kuttl In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ff0bda8
into
openstack-k8s-operators:18.0-fr1
This is an automated cherry-pick of #312
/assign olliewalsh