Fix memcached selector and labels

[lmiccini]

updating from quay.io/openstack-k8s-operators/infra-operator:dcc7dc061f30e78180a3635f0730b00409f910f1c19f93049f20aac860158ddb to quay.io/openstack-k8s-operators/infra-operator:6e7cb7a577393bff299ea199ad89845e868a41aee44f5ac5b0490b573a01c523

triggers an error because in 8e55a15 we erroneously deleted the "app" label and lib-common is not able to recreate the statefulset (nor we probably should) :

2024-11-20T01:41:04Z ERROR Reconciler error {"controller": "memcached", "controllerGroup": "memcached.openstack.org", "controllerKind": "Memcached", "Memcached": {"name":"memcached","namespace":"openstack"}, "namespace": "openstack", "name": "memcached", "reconcileID": "0155da36-541b-481d-aca3-255e24a491a2", "error": "StatefulSet.apps "memcached" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"cr":"memcached", "memcached/name":"memcached", "memcached/namespace":"openstack", "memcached/uid":"6bddcfc1-63d4-424f-8b8d-91b7dcdf0e9c", "owner":"infra-operator", "service":"memcached"}: selector does not match template labels"}

with this patch we re-add the missing "app" label so that the existing resource can be reconciled.

Jira: https://issues.redhat.com/browse/OSPRH-11797

[stuggi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stuggi]

/cherry-pick 18.0-fr1

[openshift-cherrypick-robot]

@stuggi: once the present PR merges, I will cherry-pick it on top of 18.0-fr1 in a new PR and assign it to you.

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d47d7ef31b2a472fac64bfd2a85d0afa

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 04s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 28m 21s

[lmiccini]

recheck

[abays]

@lmiccini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/infra-operator-build-deploy-kuttl 72a3070 link unknown /test infra-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

error: build error: Failed to push image: trying to reuse blob sha256:3d252ab42824f0f833f0fcf3c660065bd878cb4de12b9c69b6a1758287e338e8 at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

/test infra-operator-build-deploy-kuttl

[lmiccini]

/test infra-operator-build-deploy-kuttl

[openshift-cherrypick-robot]

@stuggi: new pull request created: #314

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.