Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Affinity to Redis #299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lmiccini
Copy link
Contributor

[zuul@controller-0 ~]$ oc get redis redis -o yaml                
apiVersion: redis.openstack.org/v1beta1
kind: Redis
metadata:                  
  annotations:                                       
    kubectl.kubernetes.io/last-applied-configuration: |                                                                                                                                                                                                                                                                                         
      {"apiVersion":"redis.openstack.org/v1beta1","kind":"Redis","metadata":{"annotations":{},"name":"redis","namespace":"openstack"},"spec":{"nodeSelector":{"foo":"bar"},"replicas":1}
  creationTimestamp: "2024-10-25T06:29:51Z"
  generation: 1                
  name: redis                                            
  namespace: openstack                                                                                                                                                                                                                                                                                                                          
  resourceVersion: "593470"                   
  uid: a6e4359d-a4f5-45d0-a09c-ff6519848986
spec:                              
  containerImage: quay.io/podified-antelope-centos9/openstack-redis@sha256:60d24dca380d2b925b13c1fedd2b28871717874755256c7e149164ec177947d3
  nodeSelector:         
    foo: bar                                      
  replicas: 1
  tls: {}
[zuul@controller-0 ~]$ oc get nodes worker-2 -o json |jq .metadata.labels.foo
"bar"
[zuul@controller-0 ~]$ oc get pods -o wide |grep redis
redis-redis-0                                                     2/2     Running     0          5m53s   192.168.48.67    worker-2   <none>           <none>

@openshift-ci openshift-ci bot requested review from stuggi and viroel October 25, 2024 06:36
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lmiccini
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Nov 21, 2024

can remove the nodeselector part as it got added with #312

@lmiccini lmiccini changed the title Add Affinity and NodeSelector to Redis Add Affinity to Redis Nov 21, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0227bfed728446a7a7764ea1e78ad7d8

openstack-k8s-operators-content-provider FAILURE in 11m 42s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@lmiccini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/infra-operator-build-deploy-kuttl 6009cd3 link true /test infra-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants