Remove KeystoneApi dependency and improve InstanceHa Conditions messages #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiccini
force-pushed
the
better-conditions
branch
from
12e62bf to
9842699
Compare
lmiccini
changed the title
lmiccini
force-pushed
the
better-conditions
branch
from
9842699 to
22da380
Compare
This commit removes the dependencing on keystonev1 api, so to avoid any circular dependency between infra-operator and keystone-operator. It also improves the conditions messages so to make the status more explicit, for example returning a status like: [zuul@controller-0 ~]$ oc get instanceha NAME STATUS MESSAGE instanceha-0 False Instance HA waiting for Fencing secret when the Fencing Secret has not been provided or created yet.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5a8704d
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the conditions messages so to make the status more explicit, for example returning a status like:
[zuul@controller-0 ~]$ oc get instanceha
NAME STATUS MESSAGE
instanceha-0 False Instance HA waiting for Fencing secret
when the Fencing Secret has not been provided or created yet.