Enable toggling tagged flavors/images and small fixes #282
Conversation
This commit fixes a couple of issues: 1. Catch case where all the faulty computes are dumping In case all the stale_computes are kdumping we want to make sure the check_kdump function returns an empty list, otherwise they may be evacuated without waiting the dump to be collected. 2. Wrap reverse dns lookup in try/except block If DNS is broken calling socket.gethostbyaddr() could result in an unexpected pod crash. Let's wrap the call in try/except with the expectation that a reverse dns lookup failure should not prevent evacuation, worst case scenario we would not capture the memory dump and the user will have a "ERROR Could not perform reverse dns lookup for: X" in the logs hinting at resolution not working. It also introduces two new config options: TAGGED_IMAGES (default=true) TAGGED_FLAVORS (default=true) Setting any of these to false will exlude respectively tagged images or flavors from being considered when deciding which vm needs to be evacuated, essentially allowing operators to decide if they want to use either tagged images or flavors, or both. Co-authored-by: Antonio Romito <[email protected]>
lmiccini
force-pushed
the
kdump-emtpy-computes
branch
from
6ad2262 to
ae42ac0
Compare
lmiccini
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ec59d3fe7b1844e6b1c57ee8f1f032d8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 38s |
|
recheck |
1 similar comment
|
recheck |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d1d7314
into
openstack-k8s-operators:main
This commit fixes a couple of issues:
Catch case where all the faulty computes are dumping
In case all the stale_computes are kdumping we want to make sure
the check_kdump function returns an empty list, otherwise they may
be evacuated without waiting the dump to be collected.
Wrap reverse dns lookup in try/except block
If DNS is broken calling socket.gethostbyaddr() could result in
an unexpected pod crash.
Let's wrap the call in try/except with the expectation that a
reverse dns lookup failure should not prevent evacuation,
worst case scenario we would not capture the memory dump and
the user will have a "ERROR Could not perform reverse dns lookup for: X"
in the logs hinting at resolution not working.
It also introduces two new config options:
TAGGED_IMAGES (default=true)
TAGGED_FLAVORS (default=true)
Setting any of these to false will exclude respectively tagged
images or flavors from being considered when deciding which vm
needs to be evacuated, essentially allowing operators to decide
if they want to use either tagged images or flavors, or both.