[memcached] add CR name length validation #245
Conversation
stuggi
requested review from
gibizer
and removed request for
viroel and
frenzyfriday
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/3c7f7a33788f4a9e8a2933b0cb07de37 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 27s |
The memcached controller creates StatefulSet for the memcached to run. This adds a StatefulSet pod's label "controller-revision-hash": "<statefulset_name>-<hash>" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. With this the max name must not exceed 52 chars. Depends-On: openstack-k8s-operators/lib-common#532 Jira: https://issues.redhat.com/browse/OSPRH-8063 Signed-off-by: Martin Schuppert <[email protected]>
The memcached controller creates StatefulSet for the memcached to run. This adds a StatefulSet pod's label "controller-revision-hash": "<statefulset_name>-<hash>" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. With this the max name must not exceed 52 chars. Also the name of the created memcached instance must match a lowercase RFC 1123. Depends-On: openstack-k8s-operators/lib-common#532 Depends-On: openstack-k8s-operators/infra-operator#245 Jira: https://issues.redhat.com/browse/OSPRH-8063 Signed-off-by: Martin Schuppert <[email protected]>
| unstructuredObj := &unstructured.Unstructured{Object: raw} | ||
| _, err := controllerutil.CreateOrPatch( | ||
| th.Ctx, th.K8sClient, unstructuredObj, func() error { return nil }) | ||
| Expect(err).To(HaveOccurred()) |
There was a problem hiding this comment.
if you want to assert the message then you can use the following pattern to extract it from the error:
https://github.com/openstack-k8s-operators/nova-operator/blob/232a1f1b9ef305d2718ad728720edae03b4322d6/test/functional/validation_webhook_test.go#L125-L137
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6191389
into
openstack-k8s-operators:main
The memcached controller creates StatefulSet for the memcached to run. This adds a StatefulSet pod's label "controller-revision-hash": "<statefulset_name>-<hash>" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. With this the max name must not exceed 52 chars. Also the name of the created memcached instance must match a lowercase RFC 1123. Depends-On: openstack-k8s-operators/lib-common#532 Depends-On: openstack-k8s-operators/infra-operator#245 Jira: https://issues.redhat.com/browse/OSPRH-8063 Signed-off-by: Martin Schuppert <[email protected]>
The memcached controller creates StatefulSet for the memcached to run. This adds a StatefulSet pod's label "controller-revision-hash": "<statefulset_name>-<hash>" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. With this the max name must not exceed 52 chars. Also the name of the created memcached instance must match a lowercase RFC 1123. Depends-On: openstack-k8s-operators/lib-common#532 Depends-On: openstack-k8s-operators/infra-operator#245 Jira: https://issues.redhat.com/browse/OSPRH-8063 Signed-off-by: Martin Schuppert <[email protected]>
The memcached controller creates StatefulSet for the memcached to run. This adds a StatefulSet pod's label
"controller-revision-hash": "<statefulset_name>-" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. With this the max name must not exceed 52 chars.
Depends-On: openstack-k8s-operators/lib-common#532
Jira: https://issues.redhat.com/browse/OSPRH-8063