[httpd] Set X-Forwarded-Proto only if empty #675
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As done for neutron-operator [1], adding a conditional to set the header only if it is empty. This is required in case we deploy with tls.podlevel=false and tls.ingress=true. [1] openstack-k8s-operators/neutron-operator#453 Signed-off-by: Francesco Pantano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit becf317
into
openstack-k8s-operators:main
7 checks passed
|
/cherry-pick 18.0-fr1 |
|
@fmount: new pull request created: #676 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done for neutron-operator [1], adding a conditional to set the header only if it is empty.
This is required in case we deploy with tls.podlevel=false and tls.ingress=true.
Jira: https://issues.redhat.com/browse/OSPRH-12376
[1] openstack-k8s-operators/neutron-operator#453