Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error messages #650

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Nov 7, 2024

Build better error messages to clarify the reason of an invalid GlanceAPI. Update functional tests and clean up some code.

Jira: https://issues.redhat.com/browse/OSPRH-11209

Build better error messages to clarify the reason of an invalid GlanceAPI.
Update functional tests and clean up some code.

Jira: https://issues.redhat.com/browse/OSPRH-11209

Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested a review from abays November 7, 2024 07:56
@openshift-ci openshift-ci bot requested review from konan-abhi and viroel November 7, 2024 07:56
@fmount fmount removed the request for review from viroel November 7, 2024 07:56
@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2024
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 749e584 into openstack-k8s-operators:main Nov 8, 2024
6 of 7 checks passed
@fmount
Copy link
Contributor Author

fmount commented Nov 18, 2024

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@fmount: new pull request created: #655

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants