Clean up jinja2 conditionals in config template #385
Conversation
The parent glance controller needs a minimal config that is adequate for generating jobs for DB sync and cronjobs. This patch uses a new "MinimalConfig" environment variable to support that goal, which eliminates the need to wrap every glanceapi variable with its own conditional.
There was a problem hiding this comment.
This is a good optimization, with an additional bool in the top-level controller we can avoid most of the checks in the 00-config template. We really need the database connection for dbsync an cronjobs, hence I'm +1 to this kind of change.
I also checked the logs and they look good: the minimal config results in:
[DEFAULT]
verbose=True
[database]
connection = **********
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ASBishop, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'll rebase the barbican patch on top of this, so we don't have to do any additional work there. Thanks @ASBishop for the help! |
openshift-merge-bot
bot
merged commit b3d8536
into
openstack-k8s-operators:main
Somehow the 00-config template introduced by PRs [1][2] has been reverted. This patch restores the missing file content. [1] openstack-k8s-operators#385 [2] openstack-k8s-operators#378 Signed-off-by: Francesco Pantano <[email protected]>
Somehow the 00-config template introduced by PRs [1][2] has been reverted. This patch restores the missing file content. [1] openstack-k8s-operators#385 [2] openstack-k8s-operators#378 Signed-off-by: Francesco Pantano <[email protected]>
Somehow the 00-config template introduced by PRs [1][2] has been reverted. This patch restores the missing file content. [1] openstack-k8s-operators#385 [2] openstack-k8s-operators#378 Signed-off-by: Francesco Pantano <[email protected]>
The parent glance controller needs a minimal config that is adequate for generating jobs for DB sync and cronjobs. This patch uses a new "MinimalConfig" environment variable to support that goal, which eliminates the need to wrap every glanceapi variable with its own conditional.