Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[envtest]Use database helpers from mariadb-operator #324

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Sep 28, 2023

This is necessary to remove a dependency cycle from lib-common

@gibizer
Copy link
Contributor Author

gibizer commented Sep 28, 2023

/hold wait for the deps

This is necessary to remove a dependency cycle from lib-common
@gibizer gibizer force-pushed the mariadb-test-helper branch from 7adf69b to 33f6261 Compare September 29, 2023 07:37
@gibizer
Copy link
Contributor Author

gibizer commented Sep 29, 2023

/unhold

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a2511a2 into openstack-k8s-operators:main Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants