Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disconnected network environments #290

Merged

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Aug 4, 2023

This PR adds support for installing the operator in disconnected network environments.

@openshift-ci openshift-ci bot requested review from fultonj and olliewalsh August 4, 2023 19:56
@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
@fmount
Copy link
Contributor

fmount commented Aug 6, 2023

/retest-required

@dprince
Copy link
Contributor Author

dprince commented Aug 6, 2023

Re the failed CI here. It seems we run 'make bundle' before our operator builds complete in CI. This should resolve the issue: openshift/release#4204

@dprince
Copy link
Contributor Author

dprince commented Aug 6, 2023

/retest

@dprince
Copy link
Contributor Author

dprince commented Aug 8, 2023

/retest

@fmount
Copy link
Contributor

fmount commented Aug 8, 2023

@dprince
Copy link
Contributor Author

dprince commented Aug 8, 2023

/test glance-operator-build-deploy-tempest

This PR adds support for installing the operator in disconnected
network environments. To build with image-digests set
USE_IMAGE_DIGESTS=true before running make bundle.

For Prow jobs we are enabling this via .prow-ci.env

This drops the old logic from create_bundle.sh which has been
broken with operator-sdk's make bundle for some time.

(NOTE: this currently requires a secure registry)
@dprince
Copy link
Contributor Author

dprince commented Aug 11, 2023

/retest

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 345713e into openstack-k8s-operators:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants