Skip to content

Commit

Permalink
set GOTOOLCHAIN min version when init go.work
Browse files Browse the repository at this point in the history
When the golang version does not match the version used inside
the build container, dowloading the modules can fail with:

~~~
go: go.work requires go >= 1.21.13 (running go 1.21.11; GOTOOLCHAIN=local)
~~~

This PR makes set the GOTOOLCHAIN to set 1.21.0 as the min required
version and sets it in go.work file.

Signed-off-by: Martin Schuppert <[email protected]>
  • Loading branch information
stuggi committed Sep 24, 2024
1 parent 350c8e0 commit ff76863
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest
## Tool Versions
KUSTOMIZE_VERSION ?= v3.8.7
CONTROLLER_TOOLS_VERSION ?= v0.11.1
GOTOOLCHAIN_VERSION ?= go1.21.0

KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"
.PHONY: kustomize
Expand Down Expand Up @@ -363,7 +364,7 @@ golint: get-ci-tools

.PHONY: gowork
gowork: ## Generate go.work file to support our multi module repository
test -f go.work || go work init
test -f go.work || GOTOOLCHAIN=$(GOTOOLCHAIN_VERSION) go work init
go work use .
go work use ./api
go work sync
Expand Down

0 comments on commit ff76863

Please sign in to comment.