-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blocked update because of health checks deployment #836
Fix blocked update because of health checks deployment #836
Conversation
Minor updates are broken due to the fact that health check scripts are deployed in install.yml task lists while the update role is using run.yml task lists Resolves: OSPRH-12088
5a52e70
to
38c799f
Compare
We need to disable podman_exporter deployment by default until we get the exporter image downstream. Resolves: OSPRH-12089
38c799f
to
b0b47e5
Compare
roles/edpm_iscsid/tasks/run.yml
Outdated
@@ -52,7 +56,6 @@ | |||
state: restarted | |||
|
|||
- name: Remove iscsid container restart sentinel file | |||
become: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is created with become: true
in the handler. why drop it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason, I must have removed it accidentally.
# List of ceilometer agents to be stopped during EDPM adoption | ||
edpm_telemetry_enabled_exporters: | ||
- ceilometer_agent_compute | ||
- node_exporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need EOF markers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
4b40559
to
d795759
Compare
d795759
to
af0c35d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paramite, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c7cc7ed
into
openstack-k8s-operators:main
/cherrypick 18.0-fr1 |
@slagle: new pull request created: #839 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Disables podman_exporter deployment by default
We need to disable podman_exporter deployment by default until we get
the exporter image downstream.
Resolves: OSPRH-12089
Moves health check script deployment to run.yml
Minor updates are broken due to the fact that health check scripts
are deployed in install.yml task lists while the update role is using
run.yml task lists
Resolves: OSPRH-12088