Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocked update because of health checks deployment #836

Conversation

paramite
Copy link
Contributor

@paramite paramite commented Dec 4, 2024

  • Disables podman_exporter deployment by default

    We need to disable podman_exporter deployment by default until we get
    the exporter image downstream.

    Resolves: OSPRH-12089

  • Moves health check script deployment to run.yml

    Minor updates are broken due to the fact that health check scripts
    are deployed in install.yml task lists while the update role is using
    run.yml task lists

    Resolves: OSPRH-12088

@paramite paramite requested review from slagle and removed request for booxter and elfiesmelfie December 4, 2024 14:10
Minor updates are broken due to the fact that health check scripts
are deployed in install.yml task lists while the update role is using
run.yml task lists

Resolves: OSPRH-12088
@paramite paramite force-pushed the OSPRH12089-OSPRH12088 branch from 5a52e70 to 38c799f Compare December 4, 2024 14:12
We need to disable podman_exporter deployment by default until we get
the exporter image downstream.

Resolves: OSPRH-12089
@paramite paramite force-pushed the OSPRH12089-OSPRH12088 branch from 38c799f to b0b47e5 Compare December 4, 2024 14:35
@@ -52,7 +56,6 @@
state: restarted

- name: Remove iscsid container restart sentinel file
become: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is created with become: true in the handler. why drop it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, I must have removed it accidentally.

# List of ceilometer agents to be stopped during EDPM adoption
edpm_telemetry_enabled_exporters:
- ceilometer_agent_compute
- node_exporter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need EOF markers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@paramite paramite force-pushed the OSPRH12089-OSPRH12088 branch from 4b40559 to d795759 Compare December 4, 2024 21:45
@paramite paramite force-pushed the OSPRH12089-OSPRH12088 branch from d795759 to af0c35d Compare December 4, 2024 21:47
@paramite paramite requested a review from jlarriba December 5, 2024 18:51
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paramite, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c7cc7ed into openstack-k8s-operators:main Dec 5, 2024
34 checks passed
@slagle
Copy link
Contributor

slagle commented Dec 5, 2024

/cherrypick 18.0-fr1

@openshift-cherrypick-robot

@slagle: new pull request created: #839

In response to this:

/cherrypick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants