Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't gather facts by default #755

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Don't gather facts by default #755

merged 1 commit into from
Sep 20, 2024

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Sep 20, 2024 •
edited
Loading

Use the ansible variable defaulting to false.

Jira: OSPRH-10279

@openshift-ci openshift-ci bot requested review from dprince and stuggi September 20, 2024 03:57
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a1f711002904546a2f4996e467a8590

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 52s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 44m 05s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 44m 15s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 49s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 01s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 53s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 01s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 59s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 10m 12s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 24s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 40s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 53s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 11m 35s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 59s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 10s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 1h 58m 21s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/93e6d9b7f2774c33afdd16917c18f223

❌ openstack-k8s-operators-content-provider FAILURE in 6m 54s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 5m 57s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 44s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 49s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 28s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 23s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 10m 48s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 52s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 43s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 6m 40s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 04s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 06s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 01s
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@rabi
Copy link
Contributor Author

rabi commented Sep 20, 2024

recheck

@rabi
Don't gather facts by default
530ba9e 
Use the ansible variable defaulting to false.

Signed-off-by: rabi <[email protected]>
slagle
slagle approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c096087 into openstack-k8s-operators:main Sep 20, 2024
35 checks passed
eduolivares added a commit to eduolivares/edpm-ansible that referenced this pull request Sep 24, 2024
@eduolivares
frr and ovn-bgp-agent molecule tests don't gather facts
03cad14 
Recently, edpm-ansible roles were updated to not gather facts by
default:
openstack-k8s-operators#755

frr and ovn-bgp-agent molecule tests are updated to not gather facts as
well.
@eduolivares eduolivares mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slagle slagle slagle approved these changes

@dprince dprince Awaiting requested review from dprince

@stuggi stuggi Awaiting requested review from stuggi

Assignees

@slagle slagle

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabi @slagle