[edpm_kernel] Improved kernel args block conditions #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions required to enter the kernel args configuration block have been refactored. The regular expression that checks for the `edpm_kernel_args` variable value presence in the command line arguments has been rewritten to intercept the substrings of the same parameters. Also, the molecule test for this particular scenario, `kernelargs-update-substring` has been rewritten to catch these kind of errors.
jpodivin
approved these changes
Aug 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpodivin, rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 95eb8df
into
openstack-k8s-operators:main
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions required to enter the kernel args configuration block have been refactored.
The regular expression that checks for the
edpm_kernel_argsvariable value presence in the command line arguments has been rewritten to intercept the substrings of the same parameters.Also, the molecule test for this particular scenario,
kernelargs-update-substringhas been rewritten to catch these kind of errors.