Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default hugepages group #721

Conversation

mrkisaolamb
Copy link
Contributor

@mrkisaolamb mrkisaolamb commented Aug 5, 2024

related: OSPRH-9065

@openshift-ci openshift-ci bot requested review from dprince and jpodivin August 5, 2024 13:43
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue triggering linter. I would also suggest to include more info about the issue. Ideally a link to JIRA. But that isn't a deal breaker.

roles/edpm_extra_mounts/defaults/main.yml Outdated Show resolved Hide resolved
@jpodivin jpodivin self-requested a review August 5, 2024 17:52
@openshift-ci openshift-ci bot added the lgtm label Aug 5, 2024
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 27a6d7f into openstack-k8s-operators:main Aug 5, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants