[edpm_nova]Configure my_ip to ctlplane_ip for nova-compute

[gibizer]

This is needed as nova-compute, if my_ip is not configured, tries to figure out its own IP address in complicated way and in a system with multiple network interfaces there is no guarantee that it selects the IP of the designated control plane interface.

The my_ip configuration is EDPM node specific so it cannot be generated globally for a cell in nova-operator. So this is generated by ansible now.

There is an upstream nova blueprint to eventually get rid of the need of this configuration: https://blueprints.launchpad.net/nova/+spec/libvirt-migrate-with-hostname-instead-of-ip

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[SeanMooney]

so... the main openquestion i have is should we introduce an ansible var to select what interface this should be or hardcode the control plane.

for context this IP will need to be included in certs and or know hosts files so we likely need a way to align this to one of the ansibel managed interface rather then just the default route.

[gibizer]

I will look into making the nova management network configurable in the role and default it to ctlplane

[gibizer]

For the sake of progress I suggest to merge this as is and get back to extend configuration later. I noted the possible future improvement inline now.

[SeanMooney]

my_ip in nova is basically the ip of the interface with the default route.
that is not in general garunetted to be the contolplane interface so i agree this is required if we want it to be the control plane interface

i have one openquestion in line so not approving for now until we agree on if we need this to be configurable as an ansible var (which would default to the contolplane IP)

[rebtoor]

my_ip in nova is basically the ip of the interface with the default route. that is not in general garunetted to be the contolplane interface so i agree this is required if we want it to be the control plane interface

If we need to retrieve the ip of the interface with the default route, what about using ansible_default_ipv4?

edit: obviously we need to be sure to have that fact first (an ansible.builtin.setup task retrieving only the network subset of facts, for example)

i have one openquestion in line so not approving for now until we agree on if we need this to be configurable as an ansible var (which would default to the contolplane IP)

[gibizer]

I will look into making the nova management network configurable in the role and default it to ctlplane

[gibizer]

my_ip in nova is basically the ip of the interface with the default route. that is not in general garunetted to be the contolplane interface so i agree this is required if we want it to be the control plane interface

If we need to retrieve the ip of the interface with the default route, what about using ansible_default_ipv4?

edit: obviously we need to be sure to have that fact first (an ansible.builtin.setup task retrieving only the network subset of facts, for example)

In the contrary, we don't want the nova default behavior (which is looking up the default route from the host) to be used as that is not guaranteed to be the IP we need to ssh between the compute nodes. So we want to set this explicitly. By default to the ctlplane_ip but maybe we want to make it configurable so the network can be defined to be used to sshe between computes.

[SeanMooney]

+1

[SeanMooney]

reapproving after the rebase

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SeanMooney,gibizer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment