Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make edpm_nodes_validation role compliant with ansible-lint production profile #430

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Make edpm_nodes_validation role compliant with ansible-lint production profile #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions roles/edpm_nodes_validation/tasks/ping.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,19 @@
INT=$(ip ro get {{ controller }} | head -1 | sed -nr "s/.* dev (\w+) .*/\1/p")
MTU=$(cat /sys/class/net/${INT}/mtu 2>/dev/null || echo "0")
echo "$INT $MTU"
changed_when:
- _nic_mtu.stdout.split()[0] != ""
- _nic_mtu.stdout.split()[1] != ""
failed_when:
- _nic_mtu.stdout.split()[0] == ""
- _nic_mtu.stdout.split()[1] == ""
- name: Set interface vars
ansible.builtin.set_fact:
_nic: "{{ _nic_mtu.stdout.split()[0] | default('lo') }}"
_mtu: "{{ _nic_mtu.stdout.split()[1] | default(0) | int - 28 }}"
- name: Network availability validation block
when:
- not ansible_check_mode|bool
- not ansible_check_mode | bool
- _nic != 'lo'
block:
- name: Check IP responsiveness
Expand All @@ -41,7 +47,7 @@
register: ping_result
until: ping_result.rc == 0

- name: Validate packet with {{ _mtu }} MTU size can reach controller from {{ _nic }}
- name: Validate packet with given MTU size can reach controller from {{ _nic }}
ansible.builtin.command: "{{ _ping_cmd }} -w 10 -s {{ _mtu }} -c 5 {{ controller }}"
retries: 10
delay: 60
Expand Down