Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix owner of the /var/lib/openstack created by the neutron_dhcp role #409

Merged

Conversation

slawqo
Copy link
Contributor

@slawqo slawqo commented Oct 6, 2023

This directory may be created by libvirt role or neutron_dhcp role and it had wrong owner set (root) when was created by edpm_neutron_dhcp role. Because of that edpm_libvirt role which was run after edpm_neutron_dhcp was failing due to permission error to access /var/lib/openstack/config/ directory.

@openshift-ci openshift-ci bot requested review from booxter and karelyatin October 6, 2023 12:16
@openshift-ci openshift-ci bot added the approved label Oct 6, 2023
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@booxter
Copy link
Contributor

booxter commented Oct 6, 2023

/approve

roles/edpm_neutron_dhcp/tasks/install.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_dhcp/tasks/install.yml Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/edpm-ansible for 409,4e4827354dd65fdd6a3c415a4fc2e7308a5645b5

This directory may be created by libvirt role or neutron_dhcp role and
it had wrong owner set (root) when was created by edpm_neutron_dhcp
role. Because of that edpm_libvirt role which was run after
edpm_neutron_dhcp was failing due to permission error to access
/var/lib/openstack/config/ directory.
@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, rebtoor, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b547875 into openstack-k8s-operators:main Oct 10, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants