Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up Ceph exclude task #386

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Speed up Ceph exclude task #386

merged 1 commit into from
Oct 3, 2023

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Oct 3, 2023 •
edited
Loading

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Oct 3, 2023
@fao89
Speed up Ceph exclude task
5d434db 
Signed-off-by: Fabricio Aguiar <[email protected]>
@fao89 fao89 mentioned this pull request Oct 3, 2023
Closed
@fao89 fao89 marked this pull request as ready for review October 3, 2023 17:36
@openshift-ci openshift-ci bot requested review from bshephar and rebtoor October 3, 2023 17:36
@fao89 fao89 requested a review from fultonj October 3, 2023 17:36
@fao89 fao89 mentioned this pull request Oct 3, 2023
Merged
@fao89 fao89 requested a review from jpodivin October 3, 2023 17:40
fultonj
fultonj approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in my HCI environment and it does the functional equivalent of what the old code did but faster.

It doesn't break it and speeds it up. Thank you @fao89 !

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, fultonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 74f9bd6 into openstack-k8s-operators:main Oct 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj fultonj approved these changes

@bshephar bshephar Awaiting requested review from bshephar

@rebtoor rebtoor Awaiting requested review from rebtoor

@jpodivin jpodivin Awaiting requested review from jpodivin

Assignees

@fultonj fultonj

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fao89 @fultonj