Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name of the config_src variable in neutron_sriov role #354

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix name of the config_src variable in neutron_sriov role #354

merged 1 commit into from
Sep 22, 2023

Conversation

slawqo
Copy link
Contributor

@slawqo slawqo commented Sep 20, 2023

No description provided.

@slawqo slawqo removed the request for review from karelyatin September 20, 2023 12:25
@slawqo slawqo requested a review from karelyatin September 20, 2023 12:25
jpodivin
jpodivin requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new variable into argspec.

@slawqo slawqo force-pushed the neutron-sriov-agent branch 3 times, most recently from c2270d7 to c314fc0 Compare September 20, 2023 13:19
@slawqo
Copy link
Contributor Author

slawqo commented Sep 20, 2023

Please add the new variable into argspec.

done

@slawqo slawqo force-pushed the neutron-sriov-agent branch from c314fc0 to 993bd2b Compare September 20, 2023 13:53
@booxter
Copy link
Contributor

booxter commented Sep 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2023
@booxter
Copy link
Contributor

booxter commented Sep 20, 2023 

        "TASK [edpm_neutron_sriov : discover secrets in /var/lib/openstack/configs/neutron-sriov] ***",
Warning: [WARNING]: Skipped '/var/lib/openstack/configs/neutron-sriov' path due to this",
        "access issue: '/var/lib/openstack/configs/neutron-sriov' is not a directory",
        "ok: [fake-sriov-compute-1 -> localhost]",

@openshift-ci openshift-ci bot removed the lgtm label Sep 21, 2023
@slawqo
Copy link
Contributor Author

slawqo commented Sep 21, 2023

recheck

        "TASK [edpm_neutron_sriov : discover secrets in /var/lib/openstack/configs/neutron-sriov] ***",
Warning: [WARNING]: Skipped '/var/lib/openstack/configs/neutron-sriov' path due to this",
        "access issue: '/var/lib/openstack/configs/neutron-sriov' is not a directory",
        "ok: [fake-sriov-compute-1 -> localhost]",

isn't it like that because there is no actually /var/lib/openstack/configs/neutron-sriov there during the molecule test?

@slawqo slawqo requested review from booxter and jpodivin September 21, 2023 09:00
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1d8ac3cc96a948d69dd9eb9160548993

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 56m 21s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 29m 28s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 17s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 16s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 25s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 12s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 20s

@booxter
Copy link
Contributor

booxter commented Sep 21, 2023

/hold

Please hold this for now, I need to check why oslo.config doesn't (apparently?) load the config for sriov agent from /etc/neutron.conf.d for you. If it doesn't, we need to understand if this applies to metadata agent too.

@booxter
Copy link
Contributor

booxter commented Sep 21, 2023

OK I know the reason why your config file with transport_url was not properly loaded. You need this fix to point molecule to the directory with the config that mimics the one from Secret prepared by neutron-operator:

diff --git a/roles/edpm_neutron_sriov/molecule/default/converge.yml b/roles/edpm_neutron_sriov/molecule/default/converge.yml
index 08d27ef..5746332 100644
--- a/roles/edpm_neutron_sriov/molecule/default/converge.yml
+++ b/roles/edpm_neutron_sriov/molecule/default/converge.yml
@@ -19,4 +19,4 @@
   roles:
     - role: "edpm_neutron_sriov"
       vars:
-        edpm_ovn_config_src: "{{lookup('env', 'MOLECULE_SCENARIO_DIRECTORY')}}/test-data"
+        edpm_neutron_sriov_agent_config_src: "{{lookup('env', 'MOLECULE_SCENARIO_DIRECTORY')}}/test-data"

With that, you should be able to:

  1. revert the patch that moves log-file from config file to command.
  2. revert the switch from neutron.conf.d to /etc/neutron/conf.d path.

booxter
booxter requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix roles/edpm_neutron_sriov/molecule/default/converge.yml to point to the right test-data path. Then revert the switch to /etc/neutron/conf.d and the move of the log-dir.

@slawqo slawqo force-pushed the neutron-sriov-agent branch from 0c9b652 to 1b3a816 Compare September 21, 2023 14:38
@slawqo
Copy link
Contributor Author

slawqo commented Sep 21, 2023

Please fix roles/edpm_neutron_sriov/molecule/default/converge.yml to point to the right test-data path. Then revert the switch to /etc/neutron/conf.d and the move of the log-dir.

Done, thx a lot :)

@booxter
Copy link
Contributor

booxter commented Sep 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 21, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/32c013446be74942ba1f89bac5ce9f10

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 02m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 48m 28s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 23m 30s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 19s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 05s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 18s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 28s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 54s

@booxter
Copy link
Contributor

booxter commented Sep 21, 2023 

error: unable to default to a user name: the server is currently unable to handle the request (get users.user.openshift.io ~)

@booxter
Copy link
Contributor

booxter commented Sep 21, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/74a465b38b8e495690e889d518844980

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 31s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 03m 53s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 08m 50s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 16s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 34s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 16s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 16s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 21s

@slawqo
Copy link
Contributor Author

slawqo commented Sep 22, 2023

recheck

karelyatin
karelyatin approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3983f8befd2245a681bcf0f8b53c16b1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 15s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 46m 34s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 24m 10s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 52s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 02s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 44s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 52s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 49s

@Sandeepyadav93
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b7984e550fbd4391a120701544c2146d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 51m 35s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 24m 36s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 09s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 11s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 37s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 02s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 02s

@slawqo
Copy link
Contributor Author

slawqo commented Sep 22, 2023

recheck

@slawqo
Copy link
Contributor Author

slawqo commented Sep 22, 2023

/retest

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5959b6ad3eb84bf18c682da15a6c7097

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 49m 12s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 07m 01s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 54s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 22s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 20s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 17s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 06s

@booxter
Copy link
Contributor

booxter commented Sep 22, 2023

recheck

@openshift-merge-robot openshift-merge-robot merged commit 594825e into openstack-k8s-operators:main Sep 22, 2023
21 checks passed
@slawqo slawqo deleted the neutron-sriov-agent branch September 26, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@booxter booxter booxter requested changes

@karelyatin karelyatin karelyatin approved these changes

@jpodivin jpodivin Awaiting requested review from jpodivin

Assignees

@booxter booxter

@karelyatin karelyatin

@jpodivin jpodivin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@slawqo @booxter @Sandeepyadav93 @karelyatin @jpodivin @openshift-merge-robot