Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovn: remove rootwrap.d from the list of filters_path #333

Merged
merged 1 commit into from
Nov 1, 2023
Merged

ovn: remove rootwrap.d from the list of filters_path #333

merged 1 commit into from
Nov 1, 2023

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Sep 14, 2023

The directory doesn't exist, and we move the filter files under /usr/share/neutron/rootwrap in rpms. See:

https://github.com/rdo-packages/neutron-distgit/blob/antelope-rdo/openstack-neutron.spec#L499

@openshift-ci openshift-ci bot requested review from fao89 and fultonj September 14, 2023 14:45
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/49fd661912b34f9aae89f80d241061a7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 18s
❌ podified-multinode-edpm-deployment-crc FAILURE in 57m 36s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 13m 58s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 8m 15s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 15s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 31s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 59s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 06s

@booxter
Copy link
Contributor Author

booxter commented Sep 15, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a841e09d10854349a1722ed9397f2702

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 32s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 52m 05s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 18m 03s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 59s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 13s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 07s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 31s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 28s

@fao89
Copy link
Contributor

fao89 commented Sep 15, 2023

@karelyatin @booxter I think you can add a group for you here: https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS_ALIASES and https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/OWNERS

@booxter booxter marked this pull request as draft September 15, 2023 14:50
@booxter
Don't configure /etc/neutron/rootwrap.d for filters_path
952e020 
The directory is empty for all the agents, and the agents are not meant to be
extended through side-loading any additional filters. It's better to keep the
list of directories that may contain escalating filters narrow, even if it
doesn't affect functionality either way.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter
Copy link
Contributor Author

booxter commented Oct 31, 2023

/hold cancel

@booxter booxter marked this pull request as ready for review October 31, 2023 20:36
@openshift-ci openshift-ci bot requested review from karelyatin and luis5tb October 31, 2023 20:37
@openshift-ci openshift-ci bot added the lgtm label Nov 1, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ebe1621 into openstack-k8s-operators:main Nov 1, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawqo slawqo slawqo approved these changes

@fao89 fao89 Awaiting requested review from fao89

@fultonj fultonj Awaiting requested review from fultonj

@karelyatin karelyatin Awaiting requested review from karelyatin

@luis5tb luis5tb Awaiting requested review from luis5tb

Assignees

@slawqo slawqo

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@booxter @fao89 @slawqo @karelyatin @openshift-merge-robot