Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role edpm_ceph_hci_pre needs become to update firewall #332

Conversation

fultonj
Copy link
Contributor

@fultonj fultonj commented Sep 14, 2023

Add become: true to tasks in firewall.yml from the role edpm_ceph_hci_pre since the move to using cloud-admin [1] exposed that we were relying on the role being run as root. When run as cloud-admin without become these tasks failed: [Errno 13] Permission denied: b'/var/lib/edpm-config/firewall'

[1] openstack-k8s-operators/install_yamls#531

Add `become: true` to tasks in firewall.yml from the role
edpm_ceph_hci_pre since the move to using cloud-admin [1]
exposed that we were relying on the role being run as root.
When run as cloud-admin without become these tasks failed:
[Errno 13] Permission denied: b'/var/lib/edpm-config/firewall'

[1] openstack-k8s-operators/install_yamls#531

Signed-off-by: John Fulton <[email protected]>
@openshift-ci openshift-ci bot requested review from jpodivin and rabi September 14, 2023 14:42
@fultonj fultonj requested review from rebtoor and fmount and removed request for rabi and jpodivin September 14, 2023 14:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, fultonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/29ef46bed3b644d3be1b9a72af6c75fc

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 31s
podified-multinode-edpm-deployment-crc FAILURE in 59m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 03m 48s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 22s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 23s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 52s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 51s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 29s

@fultonj
Copy link
Contributor Author

fultonj commented Sep 15, 2023

recheck

@openshift-merge-robot openshift-merge-robot merged commit f3fa28b into openstack-k8s-operators:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants