Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edpm_kernel: Fix Reboot Task #301

Merged

Conversation

vkhitrin
Copy link
Contributor

Reboot task may fail due to the remote user being an unprivileged user
(non root) which is not able to perform a reboot.
By escalating the permissions in the task, the reboot task should pass.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

Hi @vkhitrin. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Reboot task may fail due to the remote user being an unprivileged user
(non root) which is not able to perform a reboot.
By escalating the permissions in the task, the reboot task should pass.

Fixes openstack-k8s-operators#298.
@vkhitrin
Copy link
Contributor Author

Planning to test it on the baremetal EDPM node, which encountered this issue initially.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9d232d1e76d244689f5b5417a0a6c28d

✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 35s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 48s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 10s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 17s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 35s
✔️ edpm-ansible-content-provider SUCCESS in 1h 37m 38s
edpm-ansible-crc-podified-edpm-deployment FAILURE in 1h 24m 17s
✔️ edpm-ansible-crc-podified-edpm-baremetal SUCCESS in 48m 24s

@vkhitrin
Copy link
Contributor Author

I can confirm this works:

/tmp/key_rsa [email protected] cat /proc/cmdline
Warning: Permanently added '192.168.70.100' (ED25519) to the list of known hosts.
BOOT_IMAGE=(hd0,gpt3)/vmlinuz-5.14.0-354.el9.x86_64 root=LABEL=img-rootfs ro console=ttyS0,115200n8 no_timer_check crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M default_hugepagesz=1GB hugepagesz=1G hugepages=64 iommu=pt intel_iommu=on tsx=off isolcpus=2-47,50-95 console=ttyS0,115200 no_timer_check memtest=0 boot=LABEL=mkfs_boot skew_tick=1 nohz=on nohz_full=2-47,50-95 rcu_nocbs=2-47,50-95 tuned.non_isolcpus=00030000,00000003 intel_pstate=disable nosoftlockup

[root@edpm-compute-0 ~]# uptime
 14:55:41 up 5 min,  2 users,  load average: 0.02, 0.22, 0.14

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, vkhitrin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpodivin
Copy link
Contributor

/ok-to-test

@jpodivin
Copy link
Contributor

jpodivin commented Sep 4, 2023

recheck

@openshift-merge-robot openshift-merge-robot merged commit 5742fad into openstack-k8s-operators:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants