Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Use dhcp and ovn agent images from OpenstackVersion #905

Merged
merged 1 commit into from
May 30, 2024
Merged

Use dhcp and ovn agent images from OpenstackVersion #905

merged 1 commit into from
May 30, 2024

Conversation

karelyatin
Copy link
Contributor

@karelyatin karelyatin commented May 29, 2024 •
edited by openshift-ci bot
Loading

@openshift-ci openshift-ci bot requested review from fultonj and lewisdenny May 29, 2024 13:49
slagle
slagle reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

@slagle
Copy link
Collaborator

slagle commented May 29, 2024

/approve

@karelyatin karelyatin marked this pull request as draft May 29, 2024 14:38
@karelyatin
Copy link
Contributor Author

Marked as draft as would require updating go.mod once depends-on pr merges

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/dataplane-operator for 905,4988c8b158e2ed2d6fa14ada7edd9324ef460908

@karelyatin karelyatin marked this pull request as ready for review May 30, 2024 07:24
@openshift-ci openshift-ci bot requested review from abays and frenzyfriday May 30, 2024 07:24
@karelyatin
Copy link
Contributor Author

Marked as draft as would require updating go.mod once depends-on pr merges

updated

@openshift-ci openshift-ci bot added the lgtm label May 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9c7898e into openstack-k8s-operators:main May 30, 2024
7 checks passed
@lewisdenny lewisdenny removed their request for review June 2, 2024 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slagle slagle slagle approved these changes

@fultonj fultonj Awaiting requested review from fultonj

@abays abays Awaiting requested review from abays

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

Assignees

@slagle slagle

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karelyatin @slagle @openshift-merge-robot