Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Ensure required lists have one item at least #883

Merged
merged 1 commit into from
May 22, 2024

Conversation

fao89
Copy link
Collaborator

@fao89 fao89 commented May 13, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from jpodivin and lewisdenny May 13, 2024 09:42
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I don't think this is a beta blocker so we don't need to land it during the freeze.

@jpodivin
Copy link
Contributor

/hold

Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable change. But I'm setting hold on this to until the beta is out.

@fao89
Copy link
Collaborator Author

fao89 commented May 22, 2024

/unhold

Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 52f5c64 into openstack-k8s-operators:main May 22, 2024
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants