Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Fix Deployment statuses #739

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix Deployment statuses #739

merged 1 commit into from
Mar 7, 2024

Conversation

fao89
Copy link
Collaborator

@fao89 fao89 commented Mar 7, 2024 •
edited
Loading

condition.ReadyCondition gets reset at:

dataplane-operator/controllers/openstackdataplanedeployment_controller.go

Lines 99 to 101 in 785c63d

// something is not ready so reset the Ready condition
instance.Status.Conditions.MarkUnknown(
condition.ReadyCondition, condition.InitReason, condition.ReadyInitMessage)

For properly update the status we should use condition.DeploymentReadyCondition for deployment statuses

@openshift-ci openshift-ci bot requested review from abays and fultonj March 7, 2024 13:44
@openshift-ci openshift-ci bot added the approved label Mar 7, 2024
@fao89 fao89 marked this pull request as draft March 7, 2024 13:44
@fao89
Copy link
Collaborator Author

fao89 commented Mar 7, 2024

/test all

@fao89 fao89 marked this pull request as ready for review March 7, 2024 13:57
@openshift-ci openshift-ci bot requested review from dprince and rebtoor March 7, 2024 13:58
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0ee4e4cef7094b14aaf4a5c94deca278

✔️ openstack-k8s-operators-content-provider SUCCESS in 45m 45s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 24m 03s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 24m 23s

@fao89
Copy link
Collaborator Author

fao89 commented Mar 7, 2024

recheck

@fao89
Fix Deployment statuses
d70aa2f 
condition.ReadyCondition gets reseted at: https://github.com/openstack-k8s-operators/dataplane-operator/blob/785c63db66eb0fab41cdeffd4af897f99b8859a8/controllers/openstackdataplanedeployment_controller.go#L99-L101

For properly update the status we should use condition.DeploymentReadyCondition for deployment statuses

Signed-off-by: Fabricio Aguiar <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, jpodivin, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fao89,jpodivin,slagle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0cdf12d into openstack-k8s-operators:main Mar 7, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpodivin jpodivin jpodivin approved these changes

@slagle slagle slagle approved these changes

@abays abays Awaiting requested review from abays

@fultonj fultonj Awaiting requested review from fultonj

@dprince dprince Awaiting requested review from dprince

@rebtoor rebtoor Awaiting requested review from rebtoor

Assignees

@slagle slagle

@jpodivin jpodivin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fao89 @slagle @jpodivin