Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Add AnsibleVarsFrom #723

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

fao89
Copy link
Collaborator

@fao89 fao89 commented Feb 29, 2024

Copy link
Collaborator

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

Please add a corresponding docs patch that shows how this would be used with edpm_bootstrap_command.

@fao89 fao89 force-pushed the varsfrom branch 3 times, most recently from f656185 to 6960bad Compare March 5, 2024 12:36
@fao89 fao89 requested review from igallagh-redhat and slagle March 5, 2024 12:44
@fao89 fao89 requested a review from rebtoor March 5, 2024 14:36
pkg/deployment/inventory.go Show resolved Hide resolved
pkg/deployment/inventory.go Show resolved Hide resolved
pkg/deployment/inventory.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cfe5aa4c77b049dab3cdfb54a6c09164

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 04m 56s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 25m 34s
✔️ dataplane-operator-docs-preview SUCCESS in 2m 56s

Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. This code requires some tests, either functional or kuttl will work.

@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fdd88ea into openstack-k8s-operators:main Mar 7, 2024
7 of 8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants