-
Notifications
You must be signed in to change notification settings - Fork 47
Add AnsibleVarsFrom #723
Add AnsibleVarsFrom #723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
Please add a corresponding docs patch that shows how this would be used with edpm_bootstrap_command
.
f656185
to
6960bad
Compare
Signed-off-by: Fabricio Aguiar <[email protected]>
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cfe5aa4c77b049dab3cdfb54a6c09164 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 13s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing. This code requires some tests, either functional or kuttl will work.
Inspired by Pod's Env x EnvFrom: https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/#define-an-environment-variable-for-a-container https://github.com/kubernetes/kubernetes/blob/v1.28.7/pkg/apis/core/types.go#L2321-L2330 https://github.com/kubernetes/kubernetes/blob/v1.28.7/pkg/kubelet/kubelet_pods.go#L619 AnsibleVarsFrom will add variables from ConfigMap/Secret to the inventory, variables from AnsibleVars will take precedence Signed-off-by: Fabricio Aguiar <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, jpodivin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fdd88ea
into
openstack-k8s-operators:main
Inspired by Pod's Env x EnvFrom:
https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/#define-an-environment-variable-for-a-container
https://github.com/kubernetes/kubernetes/blob/v1.28.7/pkg/apis/core/types.go#L2321-L2330
https://github.com/kubernetes/kubernetes/blob/v1.28.7/pkg/kubelet/kubelet_pods.go#L619
AnsibleVarsFrom will add variables from ConfigMap/Secret to the inventory, variables from AnsibleVars will take precedence