This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Document hotfix process #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Slagle <[email protected]>
slagle
force-pushed
the
hotfix-process
branch
from
94875b0 to
934bc9f
Compare
fao89
reviewed
Feb 22, 2024
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-rpms.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-rpms.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-rpms.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-rpms.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-rpms.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-rpms.adoc
Outdated
Show resolved
Hide resolved
docs/assemblies/proc_hotfixing-the-data-plane-container-content-rpms.adoc
Show resolved
Hide resolved
Co-authored-by: igallagh-redhat <[email protected]>
slagle
force-pushed
the
hotfix-process
branch
from
8cbf701 to
a956816
Compare
Signed-off-by: James Slagle <[email protected]>
ciecierski
reviewed
Feb 27, 2024
| + | ||
| ---- | ||
| $ ssh <ssh_user>@<data_plane_node> | ||
| $ sudo rpm -F /tmp/hotfix-rpms/*.rpm |
There was a problem hiding this comment.
This is diffrent dir path, then in scp command above.
|
|
||
| . Update the affected `OpenStackDataPlaneNodeSet` resources by customizing the container locations to the hotfixed container locations. For more information about how to set the hotfixed container locations, see <<_customizing_container_image_locations>>. | ||
|
|
||
| . Create a new `OpenStackDataPlaneDeployment` resource that deploys the affected `OpenStackDataPlaneNodeSet` resources. For more information about how to create `OpenStackDataPlaneDeployment` resources, see <<proc_deploying-the-data-plane_{context}>>. |
There was a problem hiding this comment.
Would it make more sense to update openstackdataplanenodeset instead? Hotfixed image may be gone away on next 'normal' openstackdataplanedeployment run.
There was a problem hiding this comment.
It does say to update OpenStackDataPlaneNodeSet
fao89
reviewed
Feb 27, 2024
Comment on lines
21
to
42
| + | ||
| * Replace `<hotfix_id>` with a hotfix identifier such as a Jira issue, for example `osprh-0000`. | ||
|
|
||
| . Create a container image tagged with your registry account details and a hotfix identifier: | ||
| ---- | ||
| $ updated_container="<updated_container_registry>/<updated_container_project>/<container_image>:<hotfix_id>" | ||
| $ container=$(buildah from <container_registry>/<container_project>/<container_image>:<container_tag>) | ||
| $ buildah run --user root $container mkdir -p /<hotfix_id>/rpms | ||
| $ buildah copy --user root $container <hotfix_id>/rpms/*.rpm /hotfix_id/rpms | ||
| $ buildah run --user root rpm -F /<hotfix_id/rpms/*.rpm | ||
| $ buildah commit $container $updated_container | ||
| $ buildah push $updated_container | ||
| ---- | ||
| + | ||
| * Replace `<hotfix_id>` with a hotfix identifier such as a Jira issue, for example `osprh-0000`. | ||
| * Replace `<updated_container_registry>` with a container registry to serve the updated container image. The OCP internal container image registry can be used. | ||
| * Replace `<updated_container_project>` with a container project to use for the updated container image. | ||
| * Replace `<container_project>` with the container project for the container being updated. | ||
| * Replace `<container_registry>` with the container registry for the container being updated. | ||
| * Replace `<container_image>` with the container image being updated. | ||
| * Replace `<container_tag>` with the container tag being updated. | ||
| + |
Signed-off-by: James Slagle <[email protected]>
igallagh-redhat
approved these changes
Feb 28, 2024
docs/assemblies/proc_hotfixing-the-data-plane-container-content-images.adoc
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igallagh-redhat, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Slagle [email protected]