Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Documentation pod status reporting #636

Merged

Conversation

jpodivin
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from bshephar and slagle January 31, 2024 16:06
docs/deploying.md Outdated Show resolved Hide resolved
docs/deploying.md Outdated Show resolved Hide resolved
docs/deploying.md Outdated Show resolved Hide resolved
docs/deploying.md Outdated Show resolved Hide resolved
@jpodivin jpodivin force-pushed the pod-issues-docs branch 2 times, most recently from b81295a to cfaec74 Compare February 1, 2024 14:52
@jpodivin jpodivin requested a review from slagle February 1, 2024 14:53

Pods launched during deployement throught OpenStackAnsiblEEE managed jobs,
further referred to as pods, are are marked with label `osdpd=<OpenStackDataPlaneDeployment.Name>`
and checked for failures.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos here, and I don't think it really explains which resources owns the pods. I'd reword it to something like:

During reconciliation of OpenStackDataPlaneDeployment resources, OpenStackAnsibleEE resources are created to manage the ansible executions that configure the EDPM nodes. The OpenStackAnsibleEE resources create Kubernetes Jobs resources, which in turn create Kubernetes Pods that are executing ansible.

Checking the logs of these Jobs and Pods can show ansible failures and help diagnose issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really ought to mention the ospd= label though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

controllers/openstackdataplanenodeset_controller.go Outdated Show resolved Hide resolved
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/af11da4b75494da99338a59f4ce49c57

✔️ openstack-k8s-operators-content-provider SUCCESS in 45m 34s
podified-multinode-edpm-deployment-crc FAILURE in 26m 25s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 14s
✔️ dataplane-operator-docs-preview SUCCESS in 2m 27s

@jpodivin
Copy link
Contributor Author

jpodivin commented Feb 8, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/44e852bd071a491fa4daeca794f61cb3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 25m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 05m 31s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 12m 36s
✔️ dataplane-operator-docs-preview SUCCESS in 2m 28s

@jpodivin
Copy link
Contributor Author

recheck

@jpodivin
Copy link
Contributor Author

/retest


Checking the logs of these Jobs and Pods can show ansible failures and help diagnose issues.

Pods launched during deployement throught OpenStackAnsiblEEE managed jobs,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The pods launched..."

*through

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document doesn't exist anymore.

Checking the logs of these Jobs and Pods can show ansible failures and help diagnose issues.

Pods launched during deployement throught OpenStackAnsiblEEE managed jobs,
further referred to as pods, are are marked with label `osdpd=<OpenStackDataPlaneDeployment.Name>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop "further referrred to as pods" clause

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


Pods launched during deployement throught OpenStackAnsiblEEE managed jobs,
further referred to as pods, are are marked with label `osdpd=<OpenStackDataPlaneDeployment.Name>`
and checked for failures.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/assemblies/deploying.adoc Outdated Show resolved Hide resolved
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/20011edcf48b4edc9a04f0c0d316b08c

openstack-k8s-operators-content-provider FAILURE in 7m 31s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/578c237943c34c9db85be5080633db04

openstack-k8s-operators-content-provider FAILURE in 11m 51s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@jpodivin jpodivin force-pushed the pod-issues-docs branch 2 times, most recently from decdb45 to 82d65bf Compare February 16, 2024 15:48
@jpodivin jpodivin requested a review from slagle February 16, 2024 15:52
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/84586c7304ae42118a2a59055191f066

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 06s
podified-multinode-edpm-deployment-crc FAILURE in 23m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 04m 17s
✔️ dataplane-operator-docs-preview SUCCESS in 2m 08s

@openshift-ci openshift-ci bot removed the lgtm label Feb 16, 2024
@openshift-ci openshift-ci bot added the lgtm label Feb 16, 2024
Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7d61cae into openstack-k8s-operators:main Feb 16, 2024
7 checks passed
@jpodivin jpodivin deleted the pod-issues-docs branch February 19, 2024 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants