This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Update network-config-template to new format #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the sample files to use the new format that will accept Jinja2 files instead of a file path. We maintain the edpm_network_config_override variable for now to be backwards compatible with other projects that depend on it existing. Signed-off-by: Brendan Shephard <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/92cd5b4f25474997883d30d967a4b89b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 00s |
|
recheck |
|
/lgtm |
openshift-merge-robot
merged commit 981db11
into
openstack-k8s-operators:main
2 checks passed
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 25, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
fao89
added a commit
to fao89/data-plane-adoption
that referenced
this pull request
Sep 27, 2023
ref: openstack-k8s-operators/dataplane-operator#426 Signed-off-by: Fabricio Aguiar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the sample files to use the new format that will accept Jinja2 files instead of a file path. We maintain the edpm_network_config_override variable for now to be backwards compatible with other projects that depend on it existing.
Depends-On: openstack-k8s-operators/edpm-ansible#362
Depends-On: openstack-k8s-operators/ci-framework#581