Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adoption of octavia service #728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adoption of octavia service #728

wants to merge 1 commit into from
+503 −29

Conversation

weinimo
Copy link
Contributor

@weinimo weinimo commented Nov 13, 2024 •
edited
Loading

Octavia adoption documentation

JIRAs: OSPRH-10750 OSPNET-1078

@weinimo weinimo force-pushed the octavia-stop branch 2 times, most recently from 16136da to d7bf201 Compare November 13, 2024 11:36
@weinimo weinimo changed the title Stop octavia services in stop_openstack_services role Stop/start octavia services Nov 13, 2024
@weinimo weinimo requested review from jistr and yadneshk November 18, 2024 15:59
@weinimo weinimo force-pushed the octavia-stop branch 2 times, most recently from d61eb34 to a3291c7 Compare November 26, 2024 14:33
@weinimo weinimo changed the title Stop/start octavia services Adoption of octavia service Nov 26, 2024
@weinimo weinimo force-pushed the octavia-stop branch 9 times, most recently from ebe6304 to 7053d99 Compare November 27, 2024 13:45
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/41a8e533fe264f5cb491dd92e4ae6a1d

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 16m 51s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 53m 58s
✔️ adoption-docs-preview SUCCESS in 1m 18s

@weinimo weinimo force-pushed the octavia-stop branch 2 times, most recently from 505c13f to aaa16da Compare December 3, 2024 12:31
@weinimo weinimo mentioned this pull request Dec 3, 2024
Closed
beagles
beagles reviewed Dec 3, 2024
View reviewed changes
docs_user/modules/proc_adopting-the-loadbalancer-service.adoc
[source,bash]
----
$ CONTROLLER1_SSH="ssh -i <path to the ssh key> [email protected]"
$ CONTROLLER1_SCP="scp -i <path to the ssh key> [email protected]"
$ alias openstack="oc exec -t openstackclient -- openstack"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would 'oc rsh openstackclient' be a better choice here?'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? oc rsh openstackclient would create an interactive shell with that pod, so the openstack commands below would not work the same way. Also, lots of other services use the same alias, so using something else would be confusing.

beagles
beagles reviewed Dec 3, 2024
View reviewed changes
Copy link

@beagles beagles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a couple of questions. Also, should we include flipping the o-hm0 network configuration scripts on the controller to be ONBOOT=no?

@weinimo weinimo force-pushed the octavia-stop branch 4 times, most recently from d9fbac4 to 001e057 Compare December 4, 2024 12:54
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e9669c0258bc48a19f6171e47963b346

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph RETRY_LIMIT in 48m 57s
❌ adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 51m 02s
✔️ adoption-docs-preview SUCCESS in 1m 13s

weinimo
weinimo commented Dec 9, 2024
View reviewed changes
docs_user/modules/proc_adopting-the-loadbalancer-service.adoc
template:
apacheContainerImage: registry.redhat.io/rhel8/httpd-24:latest
amphoraImageContainerImage: quay.io/gthiemonge/octavia-amphora-image
databaseInstance: openstack
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: I hope openstack-k8s-operators/openstack-operator#1222 made this obsolete.

gthiemonge
gthiemonge reviewed Dec 11, 2024
View reviewed changes
docs_user/modules/proc_adopting-the-loadbalancer-service.adoc
spec:
ovn:
template:
ovnController:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe double check that the networkAttachment is correctly defined in ovn
you should have

ovnController:
  networkAttachment: tenant
  nicMappings:
    octavia: octbr

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/498a99163d764a2b9c7046cd7e53eab4

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 3h 00m 05s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 56m 49s
✔️ adoption-docs-preview SUCCESS in 1m 16s

jistr
jistr reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jistr jistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level the PR looks good to me, when we feel like the content is ready overall, we should also reach out to @klgill for docs refinement review.

docs_user/assemblies/proc_adopting-the-loadbalancer-dataplane.adoc Outdated Show resolved Hide resolved
@weinimo weinimo force-pushed the octavia-stop branch 5 times, most recently from f73dd0b to 9203f2a Compare December 17, 2024 17:12
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5329ccf38f6a4ad39d211634c771de27

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 2h 04m 37s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 07m 01s
❌ adoption-docs-preview FAILURE in 1m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2da5924504c545e28cfdb4f2d712b3a7

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 1h 46m 19s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 05m 23s
✔️ adoption-docs-preview SUCCESS in 1m 17s

@weinimo
Copy link
Contributor Author

weinimo commented Dec 18, 2024

recheck
mariadb issues are unrelated

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/90badcb3583f46769fcaed24784c2d01

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 2h 08m 31s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 02m 35s
✔️ adoption-docs-preview SUCCESS in 1m 18s

@weinimo
Octavia adoption docs
7715b68 
Adoption of public SSH key for Amphorae

OSPNET-1078
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/62d22a6ddd4c4c38b728efefab03f42e

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph RETRY_LIMIT in 1h 01m 16s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 08m 28s
✔️ adoption-docs-preview SUCCESS in 1m 15s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthiemonge gthiemonge gthiemonge left review comments

@beagles beagles beagles left review comments

@jistr jistr jistr left review comments

@yadneshk yadneshk Awaiting requested review from yadneshk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weinimo @jistr @beagles @gthiemonge